Thursday, 4 July 2013

if (isset($_POST['ws'])){ //ws??? wtf???

This page is written in response to the lies that +Phil Daintree  has written about me, and spread on the internet. Despite years of searching he has been unable to find anything I have written that is untrue, and he has had to resort to vague generalities, faked emails, and badly fabricated screenshots (you can see the joins if you zoom in using any bit mapped image editor). +Phil Daintree is welcome to make any comments to these pages, as he has done in the past. If I agree with what he says I will amend my writings, if I do not agree I have allowed his comments to stand next to mine so that people can make their own judgements. I have every confidence in the intelligence of readers to make a sensible judgement based on the facts. +Phil Daintree will not allow me the right of reply to any of the lies he has told about me. It seems to me significant that he realises that if people see both sides of the argument they will see through his lies.

A strange title I know, but the story behind this is typical of the dishonest and abusive style of leadership that webERP is currently suffering from. 

This comment appeared in Phil Daintree's commit here. Including comments like this in code is inappropriate. If he has a problem with some code he should speak to the author of the code privately and not litter the code with such abusive comments.

What is amusing about this though is that he hadn't bothered to look up who did this code. A simple svn command tells us who did it:

13:37:23 $ svn blame Customers.php | grep 'ws'
   297   daintree                       '. ' . _('If this does not
happen') .' (' . _('if the browser does not support META Refresh') .
') ' .
  6033   daintree if (isset($_POST['ws'])){ //ws??? wtf???
   944   daintree       $ws = $_POST['ws'];
   944   daintree } elseif (isset($_GET['ws'])){
   944   daintree       $ws = $_GET['ws'];
   194   daintree       if (DB_num_rows($result)==0){
  4594   daintree       if (DB_num_rows($result)==0){
   194   daintree       if (DB_num_rows($result)==0){
   194   daintree       if (DB_num_rows($result)==0){
   194   daintree       if (DB_num_rows($result)==0){
   944   daintree                       echo '<tr class="OddTableRows">';
   944   daintree                       echo '<tr class="EvenTableRows">';

As can be seen, it turns out the author of the code is somebody called daintree!  Once I pointed this out to him, instead of his normal trick of ridiculing the authors work, he silently removed the comment here.

If it hadn't been Phil who had authored the code, what would have happened? In 2010 a developer called Marcos Trejo with the help of Pak Ricard developed an excellent module for printing labels, which has since been used by many businesses.

However, Phil didn't like this code. Instead of speaking to Ricard and Marcos privately about this code, and how it can be improved, he started to constantly ridicule the code on the mailing list. Almost daily we would wake up to yet more personal attacks on this contribution. This is not the way to encourage new developers. It is no wonder that Marcos didn't contribute any more code.

All contributors should be treated equally. All contributors should retain the copyright to their own work. Double standards should not be applied.

No comments:

Post a Comment